This repository was archived by the owner on Feb 27, 2018. It is now read-only.
Add a sleep-loop to get the Docker daemon's tcp socket - the pid file is...#229
Merged
SvenDowideit merged 1 commit intoAug 22, 2014
Merged
Conversation
… isn't ready the first time we ask for it on one slower box I have
Contributor
Author
SvenDowideit
pushed a commit
that referenced
this pull request
Aug 22, 2014
Add a sleep-loop to get the Docker daemon's tcp socket - the pid file is...
Contributor
There was a problem hiding this comment.
For future reference, it is a good habit to put regexp.MustCompile calls outside of all functions when they are static, as they can then be processed once at startup instead of upon each function call, since regexp compilation can be an expensive operation (not that this code is time-critical)... just FYI.
Contributor
Author
There was a problem hiding this comment.
oh, thanks - good point. Its turning out to be hard to learn good go habits when learning go from a non-styled codebase :)
but you're helping immensely - thank you.
SvenDowideit
pushed a commit
to SvenDowideit/boot2docker-cli
that referenced
this pull request
Nov 10, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...n't ready the first time we ask for it on one slower box I have
and in the process, it was easier to return the error and use it...